Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add improved JSDoc support for @returns #411

Merged
merged 2 commits into from
Aug 23, 2016

Conversation

bgriffith
Copy link
Contributor

This PR adds improved support for JSDoc highlighting of @return and @returns. Currently the first word of a description will incorrectly take on the scope of a variable (an element that the @returns doesn't have http://usejsdoc.org/tags-returns.html)

Before:
screen shot 2016-08-23 at 00 22 15

After:
screen shot 2016-08-23 at 00 22 34

Also took the opportunity to tidy up the JSDoc code a bit.

@winstliu
Copy link
Contributor

Also took the opportunity to tidy up the JSDoc code a bit.

😍

@TheDutchCoder
Copy link

I'm using 0.119.0 on Mac OS and this is still an issue for me:
image

@Alhadis
Copy link
Contributor

Alhadis commented Aug 23, 2016

Ask @bgriffith to come back from the future and explain:

screen shot 2016-08-24 at 2 57 43 am

5 hours from now

Also, you ARE running a dev-linked copy of the latest changes, right?

@winstliu
Copy link
Contributor

winstliu commented Aug 23, 2016

@TheDutchCoder this fix is not yet in any released version of Atom or even language-javascript. As @Alhadis mentioned however, you can apm link it.

@bgriffith
Copy link
Contributor Author

@Alhadis Oh man wut?!! Wonder how long I've been in the future! Thanks for the heads up 😁

@Alhadis
Copy link
Contributor

Alhadis commented Aug 23, 2016

It's funny, because I'm actually the one in the future (compared to your timezone).

Lel.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants