Skip to content

fix: Optimizations #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 11, 2020
Merged

fix: Optimizations #39

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dc5cefb
fix: add css containment to minimap search result
aminya Dec 9, 2020
d030434
fix: use normal loop and object keys to loop in clear
aminya Dec 9, 2020
e41fa36
fix: use normal loop and object keys in destroy
aminya Dec 9, 2020
7e8fc11
chore: refactor function call in for of
aminya Dec 9, 2020
3fc0d9c
fix: use Map instead of object for marker subscriptions
aminya Dec 9, 2020
ca7ac16
fix: use Map instead of object for minimap subscriptions
aminya Dec 9, 2020
d12623f
fix: remove unused state
aminya Dec 9, 2020
27a6e72
chore: install @types/atom
aminya Dec 9, 2020
b74c205
chore: add big file for testing
aminya Dec 9, 2020
8498f56
Revert "chore: add big file for testing"
aminya Dec 10, 2020
424dd4b
Revert "chore: install @types/atom"
aminya Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions lib/minimap-find-and-replace-binding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,17 @@ class MinimapFindAndReplaceBinding {
}

clear () {
let id
for (id in this.subscriptionsByMarkerId) {
const sub = this.subscriptionsByMarkerId[id]
sub.dispose()
const subscriptionsByMarkerIdKeys = Object.keys(this.subscriptionsByMarkerId)
for (let i = 0, len = subscriptionsByMarkerIdKeys.length; i < len; i++) {
const id = subscriptionsByMarkerIdKeys[i]
this.subscriptionsByMarkerId[id].dispose()
delete this.subscriptionsByMarkerId[id]
}

for (id in this.decorationsByMarkerId) {
const decoration = this.decorationsByMarkerId[id]
decoration.destroy()
const decorationsByMarkerIdKeys = Object.keys(this.decorationsByMarkerId)
for (let i = 0, len = decorationsByMarkerIdKeys.length; i < len; i++) {
const id = decorationsByMarkerIdKeys[i]
this.decorationsByMarkerId[id].destroy()
delete this.decorationsByMarkerId[id]
}
}
Expand Down
1 change: 1 addition & 0 deletions styles/minimap-find-and-replace.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
@import "syntax-variables";

.minimap .search-result {
contain: layout size paint style;
background: @syntax-result-marker-color-selected;
}