fix: use normal loop and object keys in destroy

Author: aminya

lib/minimap-find-and-replace-binding.js

@@ -24,12 +24,14 @@ class MinimapFindAndReplaceBinding {
 	}
 
 	destroy () {
-		let id
-		for (id in this.subscriptionsByMarkerId) {
-			const sub = this.subscriptionsByMarkerId[id]; sub.dispose()
+		const subscriptionsByMarkerIdKeys = Object.keys(this.subscriptionsByMarkerId)
+		for (let i = 0, len = subscriptionsByMarkerIdKeys.length; i < len; i++) {
+			this.subscriptionsByMarkerId[subscriptionsByMarkerIdKeys[i]].dispose()
 		}
-		for (id in this.decorationsByMarkerId) {
-			const decoration = this.decorationsByMarkerId[id]; decoration.destroy()
+
+		const decorationsByMarkerIdKeys = Object.keys(this.decorationsByMarkerId)
+		for (let i = 0, len = decorationsByMarkerIdKeys.length; i < len; i++) {
+			this.decorationsByMarkerId[decorationsByMarkerIdKeys[i]].destroy()
 		}
 
 		this.subscriptions.dispose()