fix: use normal loop and object keys to loop in clear

Author: aminya

lib/minimap-find-and-replace-binding.js

@@ -49,16 +49,17 @@ class MinimapFindAndReplaceBinding {
 	}
 
 	clear () {
-		let id
-		for (id in this.subscriptionsByMarkerId) {
-			const sub = this.subscriptionsByMarkerId[id]
-			sub.dispose()
+		const subscriptionsByMarkerIdKeys = Object.keys(this.subscriptionsByMarkerId)
+		for (let i = 0, len = subscriptionsByMarkerIdKeys.length; i < len; i++) {
+			const id = subscriptionsByMarkerIdKeys[i]
+			this.subscriptionsByMarkerId[id].dispose()
 			delete this.subscriptionsByMarkerId[id]
 		}
 
-		for (id in this.decorationsByMarkerId) {
-			const decoration = this.decorationsByMarkerId[id]
-			decoration.destroy()
+		const decorationsByMarkerIdKeys = Object.keys(this.decorationsByMarkerId)
+		for (let i = 0, len = decorationsByMarkerIdKeys.length; i < len; i++) {
+			const id = decorationsByMarkerIdKeys[i]
+			this.decorationsByMarkerId[id].destroy()
 			delete this.decorationsByMarkerId[id]
 		}
 	}