Skip to content

Fix ci #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix ci #622

wants to merge 6 commits into from

Conversation

felipesere
Copy link
Contributor

Resolves #620 by helping the compiler infer types, use the stream::from_iter(...) function since it was move there from double_ended_stream, and finally mark the double_ended_stream module as not public.

yoshuawuyts
yoshuawuyts approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thanks heaps!

@yoshuawuyts yoshuawuyts mentioned this pull request Dec 16, 2019
Merged
@yoshuawuyts
Copy link
Contributor

Superseded by #630. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests on master failing
2 participants
@felipesere @yoshuawuyts