Skip to content

tests on master failing #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoshuawuyts opened this issue Dec 13, 2019 · 2 comments
Closed

tests on master failing #620

yoshuawuyts opened this issue Dec 13, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@yoshuawuyts
Copy link
Contributor

Looks like #562 broke the tests; the double ended from_iter function was removed, and now tests on master are broken. https://github.com/async-rs/async-std/runs/347468653

cc/ @felipesere would you mind taking a look? Ideally stream::FromIter would implement:

impl <T: DoubleEndedStream> DoubleEndedStream for FromIter<T>;

so that things just work.
@yoshuawuyts yoshuawuyts added the bug Something isn't working label Dec 13, 2019
@yoshuawuyts yoshuawuyts mentioned this issue Dec 13, 2019
Merged
@felipesere felipesere mentioned this issue Dec 13, 2019
Closed
@felipesere
Copy link
Contributor

@yoshuawuyts this can be closed now? 😄
Thanks for fixing it.

@skade
Copy link
Collaborator

skade commented Dec 16, 2019

Should be. Reopen if not true.

@skade skade closed this as completed Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ci
3 participants
@skade @felipesere @yoshuawuyts