Skip to content

Added TCP smoke tests against std Listener and Stream #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2019
Merged

Added TCP smoke tests against std Listener and Stream #429

merged 1 commit into from
Nov 2, 2019

Conversation

markhildreth
Copy link
Contributor

Adds tests which exercise the async TcpListener and TcpStream against their std library counterparts.

Resolves #407

@markhildreth markhildreth mentioned this pull request Oct 31, 2019
Closed
@ghost ghost requested a review from yoshuawuyts November 1, 2019 15:22
yoshuawuyts
yoshuawuyts approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Thanks so much!

@yoshuawuyts yoshuawuyts merged commit c413e71 into async-rs:master Nov 2, 2019
@markhildreth markhildreth deleted the tcp_smoke_tests branch November 2, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCP smoke testing
2 participants
@markhildreth @yoshuawuyts