Add Stream::poll_next #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 11, 2019
145: Add Stream::poll_next r=stjepang a=stjepang Adding `poll_next` to the `Stream` trait will simplify #125. After a discussion with @yoshuawuyts and @withoutboats, we became confident that the `Stream` trait of the future will never solely rely on `async fn next()` and will always have to rely on `fn poll_next()`. This PR now makes our `Stream` trait implementable by end users. I also made a few adjustments around pinning to `all()` and `any()` combinators since they take a `&mut self`, which implies `Self: Unpin`. A rule of thumb is that if a method takes a `&mut self` and then pins `self`, we *have to* require `Self: Unpin`. Co-authored-by: Stjepan Glavina <[email protected]>
Build succeeded
|
Merged
bors bot
added a commit
that referenced
this pull request
Sep 13, 2019
184: housekeeping after 145 r=yoshuawuyts a=montekki Now that #145 is merged combinators can follow. 1. All combinators taking `&mut self` should imply `Self: Pin`. 2. Trait bounds are to `Stream` 3. Cleans up docs and `Debug` derives. Co-authored-by: Fedor Sakharov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
poll_nextto theStreamtrait will simplify #125.After a discussion with @yoshuawuyts and @withoutboats, we became confident that the
Streamtrait of the future will never solely rely onasync fn next()and will always have to rely onfn poll_next().This PR now makes our
Streamtrait implementable by end users.I also made a few adjustments around pinning to
all()andany()combinators since they take a&mut self, which impliesSelf: Unpin. A rule of thumb is that if a method takes a&mut selfand then pinsself, we have to requireSelf: Unpin.