Skip to content

Stream::all implementation #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2019
Merged

Stream::all implementation #132

merged 5 commits into from
Aug 31, 2019

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Aug 30, 2019 •
edited
Loading

  • Adds stream::all implementation.
  • update method docs
  • an example for stream all method.
  • tests

@shekohex shekohex marked this pull request as ready for review August 30, 2019 16:59
@shekohex shekohex mentioned this pull request Aug 30, 2019
Open
87 tasks
yoshuawuyts
yoshuawuyts reviewed Aug 30, 2019
View reviewed changes
yoshuawuyts
yoshuawuyts reviewed Aug 30, 2019
View reviewed changes
yoshuawuyts
yoshuawuyts approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking 💯!!!

Shady Khalifa and others added 2 commits August 30, 2019 20:30
yoshuawuyts
yoshuawuyts approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jamesmunns
Copy link

@yoshuawuyts @shekohex is this ready to merge?

@shekohex
Copy link
Contributor Author

@jamesmunns yes!
seems ok to me

@jamesmunns jamesmunns merged commit e99eafe into async-rs:master Aug 31, 2019
@shekohex shekohex deleted the stream-all-method branch August 31, 2019 11:12
@shekohex shekohex restored the stream-all-method branch August 31, 2019 11:12
@shekohex shekohex deleted the stream-all-method branch August 31, 2019 11:12
@shekohex shekohex mentioned this pull request Aug 31, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekohex @jamesmunns @yoshuawuyts