Skip to content

Pretty Travis cfg #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Sep 3, 2019
Merged

Pretty Travis cfg #118

2 commits merged into from
Sep 3, 2019

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Aug 27, 2019

See https://travis-ci.com/async-rs/async-std/builds/124829949 for nicely separated build jobs.

@kpp kpp changed the title WIP: Pretty travis cfg Pretty Travis cfg Aug 27, 2019
@ghost ghost requested a review from skade August 27, 2019 23:38
@skade
Copy link
Collaborator

skade commented Aug 27, 2019

I'd still prefer environment config to be per matrix (to avoid the nasty "overwrite env" behaviour) or be moved into a build script in the ci folder, but otherwise, this looks good.

@kpp
Copy link
Contributor Author

kpp commented Aug 28, 2019

I'd still prefer environment config to be per matrix

Since I eliminated env vars BUILD_DOCS and BUILD_BOOK you don't need to set up env var per matrix. Every matrix build get pure RUSTFLAGS="-D warnings". I can put it down explicitly if you want but there is no difference at all. Shall I put it down?

@kpp
Copy link
Contributor Author

kpp commented Aug 28, 2019

@skade ping?

@kpp
Copy link
Contributor Author

kpp commented Aug 29, 2019

@yoshuawuyts @stjepang r?

@jamesmunns jamesmunns mentioned this pull request Aug 29, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. Thanks!

@ghost ghost merged commit dde4b89 into async-rs:master Sep 3, 2019
@kpp kpp deleted the pretty_travis branch September 3, 2019 07:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants