Skip to content

test: fix arguments #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jun 1, 2019
Merged

test: fix arguments #52

merged 1 commit into from Jun 1, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2019

Description

This PR fixes the arguments of the following functions which are expecting only 1 argument:
-common
-withPromise
-withReducer
-withDispatcher

Breaking changes

None

Checklist

Make sure you check all the boxes. You can omit items that are not applicable.

  • Implementation for both <Async> and useAsync()
  • Added / updated the unit tests
  • Added / updated the documentation
  • Updated the PropTypes
  • Updated the TypeScript type definitions

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           7        7           
  Lines         582      582           
  Branches      122      122           
=======================================
  Hits          580      580           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4255897...daa6b1f. Read the comment docs.

@ghost ghost changed the title test(useAsync.spec): fix arguments test: fix arguments Jun 1, 2019
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning that up!

@ghengeveld ghengeveld merged commit e02ee4c into async-library:master Jun 1, 2019
@ghengeveld
Copy link
Member

@all-contributors please add @noelyoo for test

@allcontributors
Copy link
Contributor

@ghengeveld

I've put up a pull request to add @noelyoo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant