Skip to content

Preserve size of mask when all values are False in HeasarcClass.locate_data #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
Merged

Preserve size of mask when all values are False in HeasarcClass.locate_data #3411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03152bd
Maintain shape in masking condition
matteobachetti Sep 16, 2025
ea9abd4
Add changelog
matteobachetti Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ heasarc
- Heasarc.locate_data returns empty rows with an error in the error_message column if there are
no data associated with that row rather than filtering it out. [#3275]
- Heasarc.locate_data changed to use POST request instead of GET to accomodate large requests. [#3356]
- Preserve size of mask when all values are False in HeasarcClass.locate_data [#3411]

imcce
^^^^^
Expand Down Expand Up @@ -2292,4 +2293,4 @@ Infrastructure, Utility and Other Changes and Additions
0.1 (2013-09-19)
================

- Initial release. Includes features!
- Initial release. Includes features!
3 changes: 2 additions & 1 deletion astroquery/heasarc/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,8 @@ def locate_data(self, query_result=None, catalog_name=None):
# that report errors (usually means there are no data products)
dl_result = dl_result[np.ma.mask_or(
dl_result['content_type'] == 'directory',
dl_result['error_message'] != ''
dl_result['error_message'] != '',
shrink=False
)]
dl_result = dl_result[['ID', 'access_url', 'content_length', 'error_message']]

Expand Down
Loading