GAIA: Fix minor issue in PR #3371 #3372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3372 +/- ##
=======================================
Coverage 70.07% 70.07%
=======================================
Files 232 232
Lines 19893 19893
=======================================
Hits 13940 13940
Misses 5953 5953 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
approved these changes
Jul 14, 2025
Contributor
keflavich
left a comment
keflavich
left a comment
There was a problem hiding this comment.
Looks like a straightforward minor bugfix & docstring update
GAIASWRQ-45 Include missing comma and include new retrieve types in the documentation.
cosmoJFH
force-pushed
the
gaia_GAIASWRQ-39_new_DL_DR4_retrieve_types
branch
from
67646a7 to
5191205
Compare
bsipocz
approved these changes
Jul 14, 2025
Member
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear astroquery team,
we found a minor issue with the PR #3371: we did not include a comma in a list of strings. We also forgot to update the documentation of the method that makes use of the new retrieve types. We would like to fix this in the PR.
Sorry for this mistake,
cc @esdc-esac-esa-int
jira: GAIASWRQ-39