Skip to content

Conversation

@snbianco
Copy link
Contributor

@snbianco snbianco commented May 7, 2025

  • Fix bug in utils.remove_duplicate_products that does not retain the order of the products in an input table.
  • Added return_uri_map parameter to Observations.get_cloud_uris to return a mapping of the input data product URIs to the returned cloud URIs.
  • Added verbose parameter to Observations.get_cloud_uris to control whether warnings are logged when a product cannot be found in the cloud.
  • Also fixed an issue with some unrelated tests/documentation. The results of the original query changed so that subsequent commands were no longer working as expected (TESS FFI observations were being returned, and we no longer allow users to get product lists for these observations). The updated queries filter out any results from TESS.

@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.88%. Comparing base (79f30f8) to head (823e49f).
⚠️ Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/mast/cloud.py 50.00% 2 Missing ⚠️
astroquery/mast/utils.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3314   +/-   ##
=======================================
  Coverage   69.87%   69.88%           
=======================================
  Files         232      232           
  Lines       19757    19761    +4     
=======================================
+ Hits        13806    13810    +4     
  Misses       5951     5951           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snbianco snbianco added the mast label May 8, 2025
Style fix

Remove unneeded line
@snbianco snbianco marked this pull request as ready for review May 8, 2025 18:48
@snbianco snbianco requested a review from bsipocz May 8, 2025 18:48
@snbianco snbianco marked this pull request as draft May 9, 2025 01:49
@snbianco snbianco marked this pull request as ready for review May 9, 2025 17:44
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks @snbianco!

@bsipocz bsipocz merged commit 8e450ca into astropy:main May 10, 2025
12 checks passed
@bsipocz bsipocz added this to the v0.4.11 milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants