Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented May 5, 2025

Functionality in setuptools got removed without deprecation (pypa/setuptools#4963), and that threw a wrench in our infrastructure, too.

However, there won't be any more helpers released on pypi, so this PR removes the usage of said setuptools functionality as a quick fix while an actual packaging modernization for astroquery is in the works.

(This will only need a changelog if we release before the full refactoring, thus I leave as is; and if needed, I'll add a changelog right before release time.)

The other workaround could be to limit setuptools version, but I'm hopeful that the change will actually be reverted soon and they will do another release.

closes #3309

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.87%. Comparing base (bca156d) to head (9d43beb).
⚠️ Report is 208 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3311   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files         232      232           
  Lines       19742    19742           
=======================================
  Hits        13795    13795           
  Misses       5947     5947           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz merged commit 7f53683 into astropy:main May 5, 2025
11 of 12 checks passed
@bsipocz bsipocz deleted the MAINT_hack_around_setuptools branch May 5, 2025 18:41
ogdru pushed a commit to ph/guix that referenced this pull request Sep 21, 2025
This version provides support for a newer setuptools, see:
<astropy/astroquery#3309>,
<astropy/astroquery#3311>.

* gnu/packages/astronomy.scm (python-astroquery): Update to 0.4.11.
[native-inputs]: Remove python-wheel.

Change-Id: Iccbb4cc3126100d532b1a42563ec7b76b4bccafa
ogdru pushed a commit to ph/guix that referenced this pull request Sep 25, 2025
This version provides support for a newer setuptools, see:
<astropy/astroquery#3309>,
<astropy/astroquery#3311>.

* gnu/packages/astronomy.scm (python-astroquery): Update to 0.4.11.
[native-inputs]: Remove python-wheel.

Change-Id: Iccbb4cc3126100d532b1a42563ec7b76b4bccafa
Millak pushed a commit to Millak/guix that referenced this pull request Sep 25, 2025
This version provides support for a newer setuptools, see:
<astropy/astroquery#3309>,
<astropy/astroquery#3311>.

* gnu/packages/astronomy.scm (python-astroquery): Update to 0.4.11.
[native-inputs]: Remove python-wheel.

Change-Id: Iccbb4cc3126100d532b1a42563ec7b76b4bccafa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package build fails due to removal of setuptools.package_index

1 participant