Skip to content

Conversation

@jeffjennings
Copy link
Contributor

@jeffjennings jeffjennings commented Feb 28, 2025

This PR adds a banner (like the recent one for 10k citations to Astropy paper I) that advertises the astropy user survey, which will close on April 1. I should've thought of adding this banner sooner, but I'm hoping to get this merged quickly, as the survey just opened. Thanks! (I can of course submit another PR to remove this content on April 2.)

@jeffjennings
Copy link
Contributor Author

@pllim Would you mind reviewing this? I saw that you were adding/removing the 10k citations announcement content, which I just copied/modified here. Thank you!

@pllim
Copy link
Member

pllim commented Feb 28, 2025

@mhvk was getting annoyed by the banner, so maybe he should review. Technically looks okay. Thanks!

@pllim pllim requested review from hamogu and mhvk February 28, 2025 15:03
@adrn
Copy link
Member

adrn commented Feb 28, 2025

I would prefer to ask the webpage maintainers on this rather than singling out @mhvk as one potentially negative opinion! I'm sure there will be a diversity of opinions but I don't think this is something we need to ask the entire project about...

@adrn
Copy link
Member

adrn commented Feb 28, 2025

Can you request reviews from @dhomeier and @eteq?

@mhvk
Copy link
Contributor

mhvk commented Feb 28, 2025

FWIW, I liked the 10000 citations banner but felt that after having been there for a while, it should no longer be on every page, just on the landing page.

For the user survey, having it everywhere makes sense, let's just not have it there for too long (or can we ensure someone doesn't see it more than once a week or so?? but that probably needs cookies, etc., so not great...).

Anyway, bottom line: let's be sure that there is an expiration day set now!

@jeffjennings
Copy link
Contributor Author

FWIW, I liked the 10000 citations banner but felt that after having been there for a while, it should no longer be on every page, just on the landing page.

For the user survey, having it everywhere makes sense, let's just not have it there for too long (or can we ensure someone doesn't see it more than once a week or so?? but that probably needs cookies, etc., so not great...).

Anyway, bottom line: let's be sure that there is an expiration day set now!

Thanks Marten! That sounds good - we're keeping the survey open until April 1, so I'm happy to submit another PR to remove the banner on April 2.

@pllim pllim requested review from dhomeier and eteq February 28, 2025 20:28
@jeffjennings
Copy link
Contributor Author

Would someone mind merging this in? I know the website maintainers are tagged for review, but anyway I don't think this is controversial (and it's temporary). The more people visiting the site we can reach, the bigger impact it can have on the user survey!

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I haven't seen any adverse opinions in the end!

@hamogu hamogu merged commit fb0d0db into astropy:main Mar 3, 2025
2 checks passed
@jeffjennings
Copy link
Contributor Author

Thank you @dhomeier and @hamogu! I'll submit another PR in 1 month to remove the banner.

@jeffjennings jeffjennings mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants