-
-
Notifications
You must be signed in to change notification settings - Fork 107
Add banner for survey announcement #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pllim Would you mind reviewing this? I saw that you were adding/removing the 10k citations announcement content, which I just copied/modified here. Thank you! |
|
@mhvk was getting annoyed by the banner, so maybe he should review. Technically looks okay. Thanks! |
|
I would prefer to ask the webpage maintainers on this rather than singling out @mhvk as one potentially negative opinion! I'm sure there will be a diversity of opinions but I don't think this is something we need to ask the entire project about... |
|
FWIW, I liked the 10000 citations banner but felt that after having been there for a while, it should no longer be on every page, just on the landing page. For the user survey, having it everywhere makes sense, let's just not have it there for too long (or can we ensure someone doesn't see it more than once a week or so?? but that probably needs cookies, etc., so not great...). Anyway, bottom line: let's be sure that there is an expiration day set now! |
Thanks Marten! That sounds good - we're keeping the survey open until April 1, so I'm happy to submit another PR to remove the banner on April 2. |
|
Would someone mind merging this in? I know the website maintainers are tagged for review, but anyway I don't think this is controversial (and it's temporary). The more people visiting the site we can reach, the bigger impact it can have on the user survey! |
dhomeier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I haven't seen any adverse opinions in the end!
This PR adds a banner (like the recent one for 10k citations to Astropy paper I) that advertises the astropy user survey, which will close on April 1. I should've thought of adding this banner sooner, but I'm hoping to get this merged quickly, as the survey just opened. Thanks! (I can of course submit another PR to remove this content on April 2.)