Use HTTPS for docs.astropy.org URLs #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamogu
reviewed
Sep 24, 2024
| </p> | ||
| <p> | ||
| <a href="http://docs.astropy.org/en/stable/whatsnew/0.4.html">http://docs.astropy.org/en/stable/whatsnew/0.4.html</a> | ||
| <a href="https://docs.astropy.org/en/stable/whatsnew/0.4.html">https://docs.astropy.org/en/stable/whatsnew/0.4.html</a> |
Member
There was a problem hiding this comment.
This one gives me a 404 when I try either the old or the new version. So, not a problem for this PR (was broken before I broken now).
hamogu
approved these changes
Sep 24, 2024
Member
hamogu
left a comment
hamogu
left a comment
There was a problem hiding this comment.
I checked a few links manually. I don't see anything that's broken by this PR - nor should it.
Member
Author
|
Re: 404 -- That is weird because the link works for me. 
|
Member
Author
|
Thanks for the quick review/merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #610
Just a blind search and replace:
find ./ -type f -exec sed -i 's/http:\/\/docs\.astropy/https:\/\/docs\.astropy/g' {} \;