Expose Indentation in ruff_python_codegen
#20216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ntBre
approved these changes
Sep 3, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Makes sense to me, thank you!
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
## Summary I'm trying to reduce code complexity for [RustPython](https://github.com/RustPython/RustPython), we have this file: https://github.com/RustPython/RustPython/blob/056795eed4dc0b09de00c2fabe45493ea1de7194/compiler/codegen/src/unparse.rs which can be replaced entirely by `ruff_python_codegen::Generator`. Unfortunately we can not create an instance of `Generator` easily, because `Indentation` is not exported at https://github.com/astral-sh/ruff/blob/cda376afe079b54b6779704bdd740c9e81423e39/crates/ruff_python_codegen/src/lib.rs#L3 I have managed to bypass this restriction by doing: ```rust let contents = r"x = 1"; let module = ruff_python_parser::parse_module(contents).unwrap(); let stylist = ruff_python_codegen::Stylist::from_tokens(module.tokens(), contents); stylist.indentation() ``` But ideally I'd rather use: ```rust ruff_python_codegen::Indentation::default() ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm trying to reduce code complexity for RustPython, we have this file: https://github.com/RustPython/RustPython/blob/056795eed4dc0b09de00c2fabe45493ea1de7194/compiler/codegen/src/unparse.rs which can be replaced entirely by
ruff_python_codegen::Generator. Unfortunately we can not create an instance ofGeneratoreasily, becauseIndentationis not exported atruff/crates/ruff_python_codegen/src/lib.rs
Line 3 in cda376a
I have managed to bypass this restriction by doing:
But ideally I'd rather use: