Cache dependency downloads on Linux #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofft
approved these changes
Mar 17, 2025
Merged
zanieb
commented
Mar 17, 2025
Comment on lines
+223
to
+226
| key: ${{ matrix.target_triple }}-${{ hashFiles('pythonbuild/downloads.py')}} | ||
| restore-keys: | | ||
| ${{ matrix.target_triple }}-${{ hashFiles('pythonbuild/downloads.py')}} | ||
| ${{ matrix.target_triple }}- |
There was a problem hiding this comment.
We could also add the OS to the key and use that as a final level match?
zanieb
changed the title
zanieb
added a commit
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #565 we note we're seeing rate-limiting on downloads of bzip2 — which is blocking development here. There, we increase the exponential backoff but we need to reduce the number of downloads to address the root cause of the issue. @geofft suggested caching these downloads, which makes a lot of sense for us — there's already logic to validate the file if it exists on disk.
I'm just starting with Linux.