Skip to content

Conversation

@mchmielarz
Copy link
Contributor

No description provided.

@mchmielarz mchmielarz added this to the v0.4.1 milestone Oct 7, 2021
@mchmielarz mchmielarz requested review from Opalo and pivovarit October 7, 2021 09:39
@mchmielarz mchmielarz self-assigned this Oct 7, 2021
@mchmielarz mchmielarz modified the milestones: v0.4.1, v0.4.3 Oct 7, 2021
@mchmielarz
Copy link
Contributor Author

@pivovarit Would you look at it too? :D

@mchmielarz mchmielarz requested a review from Grandys March 18, 2023 18:50
Copy link

@Grandys Grandys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments regarding documentation, code looks good 👍

@Opalo
Copy link

Opalo commented Apr 11, 2023

WUT :D What happens here? It's still not merged, after a year and a half? :D

@mchmielarz
Copy link
Contributor Author

@Opalo I've been waiting for the review for whole this time (pun intended) ;)

@mchmielarz mchmielarz requested a review from pivovarit as a code owner April 11, 2023 20:04
@mchmielarz mchmielarz force-pushed the feature/162-validation-satisfying-condition branch from 1def0e7 to 3a1724e Compare April 12, 2023 20:51
@mchmielarz mchmielarz requested a review from Grandys April 12, 2023 21:57
Copy link

@Grandys Grandys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mchmielarz mchmielarz merged commit 63f907f into main Apr 13, 2023
@mchmielarz mchmielarz deleted the feature/162-validation-satisfying-condition branch April 13, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants