Skip to content

feat(filter): Unordered match support #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 23, 2024
Merged

feat(filter): Unordered match support #330

merged 19 commits into from
May 23, 2024

Conversation

@epage
Copy link
Contributor

@epage epage commented May 23, 2024

Fixes #151

epage added 19 commits May 23, 2024 15:47
@epage
refactor(filter): Pull out pattern logic
7077675
@epage
refactor(filter): Remove a layer of abstraction
a0d8c54
@epage
refactor(filter): Centralize all pattern normalization
e10b8d6
@epage
docs(filter): Improve Redactions examples
adf5bf5
@epage
fix(filter)!: Remove Redactions::normalize
f132eac 
This interface is too simplistic for what we'll be needing
@epage
fix(filter)!: Rename FilterRedactions to NormalizeToExpected
5f99d98
@epage
fix(filter)!: Replace Filter::filter with NormalizeToExpected::normalize
6e8afe1
@epage
fix(filter)!: Clarify normalizing actual needs specific expected
5227854
@epage
feat(filter): Allow const construction of Redactions
ba303b3
@epage
fix(filter)!: Split NormalizeToExpected construction
bb11bc3
@epage
fix(filter)!: Require opt-in for built-in redactions
c765a4c
@epage
refactor(filter): Specialize normalization fn
4e4250b
@epage
refactor(filter): Pull out normalization fn
ac0acd4
@epage
refactor(filter): Clarify test names
a83e4d1
@epage
test(filter): Transition unit tests to end-to-end tests
c5c688e
@epage
refactor(filter): Consolidate end-to-end tests
8d465cf
@epage
refactor(filter): Perform a distint redaction pass
f08fd7a
@epage
refactor(filter): Split up tests
c44c6f4
@epage
feat(filter): Unordered match support
4134e1a 
Fixes assert-rs#151
@epage epage enabled auto-merge May 23, 2024 20:59
@coveralls
Copy link

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9214759463

Details

  • 125 of 184 (67.93%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 51.54%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/snapbox/src/assert/mod.rs 4 5 80.0%
crates/snapbox/src/data/filters.rs 2 5 40.0%
crates/snapbox/src/data/mod.rs 0 5 0.0%
crates/snapbox/src/filter/redactions.rs 14 21 66.67%
crates/snapbox/src/filter/pattern.rs 98 141 69.5%
Files with Coverage Reduction New Missed Lines %
crates/snapbox/src/cmd.rs 1 34.83%
crates/snapbox/src/filter/redactions.rs 1 72.12%
Totals Coverage Status
Change from base Build 9214593810: 0.2%
Covered Lines: 1372
Relevant Lines: 2662
💛 - Coveralls

@epage epage merged commit 3803df6 into assert-rs:main May 23, 2024
@epage epage deleted the unordered branch May 23, 2024 21:01
@weihanglo weihanglo mentioned this pull request Jun 19, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sorting output for tests

2 participants

@epage @coveralls