fix(API): Switch from Associated Types to Generics #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hope is that generics will also make implementing support for assert-rs#20 easier. So when to use each according to [The Book](https://doc.rust-lang.org/book/second-edition/ch19-03-advanced-traits.html#associated-types-versus-generics): Generics - Used when type is going to be function input - Can have multiple implementations of trait Associated types - Used when type is going to be a function output, like iterator - Avoids need to annotate type - Can only have one implementation of trait BREAKING CHANGE: The `Predicate` trait's API has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hope is that generics will also make implementing support for #20
easier. If nothing else, they'll give more control to users to implement things how they want.
So when to use each according to The
Book:
Generics
Associated types
BREAKING CHANGE: The
Predicatetrait's API has changed.