perf(cargo): Faster bin lookup #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an experiemnt in a new direction in trying to resolve - Cargo overhead (assert-rs#6) - Compile times from mismatched `--target` (assert-rs#57) - Suprising behavior if `--target <triplet>` isn't specified (assert-rs#4) The new downsides this introduces - No `main_binary` or `cargo_example` - Can only work within integration tests We're recommending the use of `escargot` in these cases which I think might be reasonable because instead of making policy decisions for the user, and no one ever being happy, the user can choose which policy they want. Plus, in more complex cases they should already be using `escargot` so they can cache. Fixes assert-rs#6 Fixes assert-rs#57 BREAKING CHANGE: `main_binary` / `cargo_example` no longer exist. Also, successfully running `cargo_bin` has been restricted to integration tests.
This was referenced Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiemnt in a new direction in trying to resolve
main_binarytakes ~300ms per invocation #6)--target(main_binarytakes minutes on first run #57)--target <triplet>isn't specified (main_binaryshould reuse the caller's target #4)The new downsides this introduces
main_binaryorcargo_exampleWe're recommending the use of
escargotin these cases which I thinkmight be reasonable because instead of making policy decisions for the
user, and no one ever being happy, the user can choose which policy they
want. Plus, in more complex cases they should already be using
escargotso they can cache.Fixes #6
Fixes #57