Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Review Jwt vs OIDC handling of TVP.ValidIssuer vs ValidIssuers #1208

Closed
Tratcher opened this issue May 9, 2017 · 3 comments
Closed

Review Jwt vs OIDC handling of TVP.ValidIssuer vs ValidIssuers #1208

Tratcher opened this issue May 9, 2017 · 3 comments
Assignees
Milestone

Comments

@Tratcher
Copy link
Member

Tratcher commented May 9, 2017

Inspired by: aspnet/AspNetKatana#55
Jwt and OIDC don't use the same logic for dealing with Issuers:

var validationParameters = Options.TokenValidationParameters.Clone();
if (_configuration != null)
{
if (validationParameters.ValidIssuer == null && !string.IsNullOrEmpty(_configuration.Issuer))
{
validationParameters.ValidIssuer = _configuration.Issuer;
}
else
{
var issuers = new[] { _configuration.Issuer };
validationParameters.ValidIssuers = (validationParameters.ValidIssuers == null ? issuers : validationParameters.ValidIssuers.Concat(issuers));
}
validationParameters.IssuerSigningKeys = (validationParameters.IssuerSigningKeys == null ? _configuration.SigningKeys : validationParameters.IssuerSigningKeys.Concat(_configuration.SigningKeys));
}

if (_configuration != null)
{
if (string.IsNullOrEmpty(validationParameters.ValidIssuer))
{
validationParameters.ValidIssuer = _configuration.Issuer;
}
else if (!string.IsNullOrEmpty(_configuration.Issuer))
{
validationParameters.ValidIssuers = validationParameters.ValidIssuers?.Concat(new[] { _configuration.Issuer }) ?? new[] { _configuration.Issuer };
}
validationParameters.IssuerSigningKeys = validationParameters.IssuerSigningKeys?.Concat(_configuration.SigningKeys) ?? _configuration.SigningKeys;
}

@Tratcher
Copy link
Member Author

Tratcher commented May 9, 2017

@brentschmaltz

@Eilon
Copy link
Contributor

Eilon commented Jun 15, 2017

@Tratcher - can you set up a few minutes with @brentschmaltz to go over this?

@Eilon Eilon added this to the 2.0.0 milestone Jun 15, 2017
@Eilon Eilon added the task label Jun 15, 2017
@Tratcher
Copy link
Member Author

IM will look at both the single value and the list, so we can simplify the code to always work with the list at our layer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants