Implement Http cache #15
Conversation
| @@ -45,11 +45,17 @@ public void Remove(string key) | |||
| } | |||
| } | |||
|
|
|||
| public void Set(string key, object entry) | |||
| public void Set(string key, object entry, TimeSpan validUntil) | |||
There was a problem hiding this comment.
validUntil is a strange name for a TimeSpan
|
So far so good. |
JunTaoLuo
force-pushed
the
johluo/http-cache-implementation
branch
from
5cfc0da to
fe6ef55
Compare
| { | ||
| var client = server.CreateClient(); | ||
| var initialResponse = await client.GetAsync(""); | ||
| client.DefaultRequestHeaders.CacheControl = new System.Net.Http.Headers.CacheControlHeaderValue() |
There was a problem hiding this comment.
@Tratcher is there any reason we have our own version of CacheControlHeaderValue? It looks very similar to the one in System.Net.Http.Headers.
There was a problem hiding this comment.
Yeah, we cloned most of System.Net.Http.Headers in order to make out-of-band usability and perf improvements.
| namespace Microsoft.AspNetCore.ResponseCaching | ||
| { | ||
| public interface IResponseCache | ||
| { | ||
| object Get(string key); | ||
| // TODO: Set expiry policy in the underlying cache? | ||
| void Set(string key, object entry); | ||
| void Set(string key, object entry, TimeSpan validFor); |
There was a problem hiding this comment.
We might need a context object here. What other things will we need to pass?
There was a problem hiding this comment.
What do we need in the context object? Should we add that when we actually need it?
|
ping @davidfowl @Tratcher |
|
|
||
| if (body.Length > 0) | ||
| { | ||
| await response.Body.WriteAsync(body, 0, body.Length).SupressContext(); |
| // Finalize the cache entry | ||
| cachingContext.FinalizeCaching(); | ||
| cachingContext.FinalizeCachingBody(); | ||
| } | ||
| finally |
There was a problem hiding this comment.
catch { disable response caching; throw; }
There was a problem hiding this comment.
No need, response caching is only completed if everything succeeds. Early exit by default behaves as if caching was disabled.
JunTaoLuo
force-pushed
the
johluo/http-cache-implementation
branch
from
b57dcbe to
dc4212c
Compare
| public async Task SendFileAsync(string path, long offset, long? length, CancellationToken cancellation) | ||
| { | ||
| _responseCacheStream.DisableBuffering(); | ||
| await _originalSendFileFeature.SendFileAsync(path, offset, length, cancellation); |
|
|
JunTaoLuo
force-pushed
the
johluo/http-cache-implementation
branch
from
4e732b9 to
62aabc1
Compare
todos:
cc @Tratcher @davidfowl