Feedback

JunTaoLuo · JunTaoLuo · commit 5cfc0da64409 · 2016-08-05T11:35:32.000-07:00
diff --git a/src/Microsoft.AspNetCore.ResponseCaching/ResponseCachingContext.cs b/src/Microsoft.AspNetCore.ResponseCaching/ResponseCachingContext.cs
@@ -23,6 +23,7 @@ public class ResponseCachingContext
         private CacheControlHeaderValue _requestCacheControl;
         private CacheControlHeaderValue _responseCacheControl;
         private DateTimeOffset _responseTime;
+        private static readonly CacheControlHeaderValue EmptyCacheControl = new CacheControlHeaderValue();
 
         public ResponseCachingContext(HttpContext httpContext, IResponseCache cache)
         {
@@ -78,7 +79,7 @@ private CacheControlHeaderValue RequestCacheControl
             {
                 if (_requestCacheControl == null)
                 {
-                    _requestCacheControl = RequestHeaders.CacheControl ?? new CacheControlHeaderValue();
+                    _requestCacheControl = RequestHeaders.CacheControl ?? EmptyCacheControl;
                 }
                 return _requestCacheControl;
             }
@@ -90,7 +91,7 @@ private CacheControlHeaderValue ResponseCacheControl
             {
                 if (_responseCacheControl == null)
                 {
-                    _responseCacheControl = ResponseHeaders.CacheControl ?? new CacheControlHeaderValue();
+                    _responseCacheControl = ResponseHeaders.CacheControl ?? EmptyCacheControl;
                 }
                 return _responseCacheControl;
             }
@@ -329,7 +330,6 @@ internal async Task<bool> TryServeFromCacheAsync()
 
                         if (_responseType == ResponseType.HeadersOnly)
                         {
-                            response.ContentLength = 0;
                             responseServed = true;
                         }
                         else if (_responseType == ResponseType.FullReponse)

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ public class ResponseCachingContext`
`23`	`23`	`private CacheControlHeaderValue _requestCacheControl;`
`24`	`24`	`private CacheControlHeaderValue _responseCacheControl;`
`25`	`25`	`private DateTimeOffset _responseTime;`
	`26`	`+ private static readonly CacheControlHeaderValue EmptyCacheControl = new CacheControlHeaderValue();`
`26`	`27`
`27`	`28`	`public ResponseCachingContext(HttpContext httpContext, IResponseCache cache)`
`28`	`29`	`{`
`@@ -78,7 +79,7 @@ private CacheControlHeaderValue RequestCacheControl`
`78`	`79`	`{`
`79`	`80`	`if (_requestCacheControl == null)`
`80`	`81`	`{`
`81`		`- _requestCacheControl = RequestHeaders.CacheControl ?? new CacheControlHeaderValue();`
	`82`	`+ _requestCacheControl = RequestHeaders.CacheControl ?? EmptyCacheControl;`
`82`	`83`	`}`
`83`	`84`	`return _requestCacheControl;`
`84`	`85`	`}`
`@@ -90,7 +91,7 @@ private CacheControlHeaderValue ResponseCacheControl`
`90`	`91`	`{`
`91`	`92`	`if (_responseCacheControl == null)`
`92`	`93`	`{`
`93`		`- _responseCacheControl = ResponseHeaders.CacheControl ?? new CacheControlHeaderValue();`
	`94`	`+ _responseCacheControl = ResponseHeaders.CacheControl ?? EmptyCacheControl;`
`94`	`95`	`}`
`95`	`96`	`return _responseCacheControl;`
`96`	`97`	`}`
`@@ -329,7 +330,6 @@ internal async Task<bool> TryServeFromCacheAsync()`
`329`	`330`
`330`	`331`	`if (_responseType == ResponseType.HeadersOnly)`
`331`	`332`	`{`
`332`		`- response.ContentLength = 0;`
`333`	`333`	`responseServed = true;`
`334`	`334`	`}`
`335`	`335`	`else if (_responseType == ResponseType.FullReponse)`