This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Reacting to Hosting changes #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JunTaoLuo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| private Stack<IDisposable> _disposables; | ||
| private IHttpContextFactory _httpContextFactory; | ||
|
|
||
| public IFeatureCollection Features { get; } |
There was a problem hiding this comment.
Put property after constructor.
|
⌚ very straightforward change. |
| @@ -184,6 +185,8 @@ public Task Stop() | |||
| } | |||
| finally | |||
| { | |||
| HttpContextFactory.Dispose(httpContext); | |||
There was a problem hiding this comment.
This needs to happen after FireOnStarting and FireOnCompleted. Both these methods execute user code.
|
cc @lodejard |
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| using System; | |||
| using System.Threading.Tasks; | |||
| using Microsoft.AspNet.Builder; | |||
JunTaoLuo
force-pushed
the
johluo/iserverfactory-refactoring
branch
from
c3e57ab to
4f702fb
Compare
|
ping @troydai @halter73 @davidfowl |
|
|
JunTaoLuo
force-pushed
the
johluo/iserverfactory-refactoring
branch
from
4f702fb to
b466c3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#258 and also responding to aspnet/Hosting#445