Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Call new IHttpContextFactory.Dispose(...) from request end #258

Closed
Eilon opened this issue Oct 13, 2015 · 2 comments
Closed

Call new IHttpContextFactory.Dispose(...) from request end #258

Eilon opened this issue Oct 13, 2015 · 2 comments
Assignees
@JunTaoLuo
Labels
3 - Done bug
Milestone
1.0.0-rc2

Comments

@Eilon
Copy link
Contributor

Eilon commented Oct 13, 2015

In here: https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Microsoft.AspNet.Server.Kestrel/Http/Frame.cs#L175-L196

Before the try do the create, and in the finally do the dispose.

See new API in aspnet/Hosting#404.
@Eilon Eilon added this to the 1.0.0-rc1 milestone Oct 13, 2015
@Eilon Eilon changed the title Call new IHttpContextFactory.Dispose(...) from Call new IHttpContextFactory.Dispose(...) from request end Oct 13, 2015
@muratg
Copy link
Contributor

muratg commented Oct 22, 2015

Same as WebListener, your hosting changes have potential to break these.

@muratg muratg modified the milestones: 1.0.0-rc2, 1.0.0-rc1 Oct 26, 2015
@JunTaoLuo JunTaoLuo mentioned this issue Oct 29, 2015
Merged
@JunTaoLuo
Copy link
Contributor

merged to dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
3 participants
@Eilon @muratg @JunTaoLuo