This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Prepare to 0 byte flush change #2442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
commented
Mar 29, 2018
| writer.WriteAsciiNoValidation(input); | ||
| writer.Commit(); | ||
| writerBuffer.FlushAsync().GetAwaiter().GetResult(); | ||
| pipeWriter.FlushAsync().GetAwaiter().GetResult(); | ||
| pipeWriter.Complete(); |
There was a problem hiding this comment.
We have to .Complete now because of empty/null string test cases.
halter73
approved these changes
Mar 30, 2018
|
CI Failures unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.