Merge and rename packages and components to HttpSys* #286
Conversation
| { | ||
| return hostBuilder.ConfigureServices(services => { | ||
| services.AddTransient<IConfigureOptions<WebListenerOptions>, WebListenerOptionsSetup>(); |
There was a problem hiding this comment.
It was used to set up a logger, which can now be passed directly from DI.
| @@ -23,6 +23,7 @@ | |||
| }, | |||
| "net451": { | |||
| "frameworkAssemblies": { | |||
| "System.DirectoryServices": "", | |||
There was a problem hiding this comment.
The NTLM tests only work on domain.
There was a problem hiding this comment.
What APIs are you using that you weren't using before (or did I just miss that).
There was a problem hiding this comment.
This isn't new, it's just merged from the other test project.
| { | ||
| internal class ResponseStream : Stream | ||
| internal class ResponseBody : Stream |
There was a problem hiding this comment.
There were two ResponseSteam classes. I may be able to de-duplicate later.
| @@ -13,6 +13,7 @@ internal static class Constants | |||
| internal const string Close = "close"; | |||
| internal const string Zero = "0"; | |||
| internal const string SchemeDelimiter = "://"; | |||
| internal const int Status101SwitchingProtocols = 101; | |||
There was a problem hiding this comment.
Should this be moved to StatusCodes in HttpAbstractions?
There was a problem hiding this comment.
Sure. Can you add that this week?
There was a problem hiding this comment.
Kestrel could use it too: https://github.com/aspnet/KestrelHttpServer/search?utf8=%E2%9C%93&q=101
There was a problem hiding this comment.
aspnet/HttpAbstractions#748, any other status codes we want to add?
Tratcher
force-pushed
the
tratcher/squash
branch
from
32f7298 to
f07e7a5
Compare
|
@JunTaoLuo Your commit regressed the tests xplat 3b42433. You forgot to make them conditional like all of the others. |
|
@Tratcher ah I see. Didn't realize those need to be updated. |
#283
Stage 1: merge packages, namespaces, tests, initial renames, reduced object visibility
Future work: