Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Don't throw for OnStarting or OnCompleted calls. #864

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Don't throw for OnStarting or OnCompleted calls. #864

merged 1 commit into from
Jun 8, 2017

Conversation

davidfowl
Copy link
Member

I had to implement a ResponseFeature in SignalR that doesn't throw because we do by default. It really shouldn't throw.

@davidfowl davidfowl requested a review from Tratcher June 8, 2017 06:53
@davidfowl davidfowl mentioned this pull request Jun 8, 2017
Merged
@davidfowl davidfowl requested a review from JunTaoLuo June 8, 2017 17:45
JunTaoLuo
JunTaoLuo approved these changes Jun 8, 2017
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these defaults meant to be overridden? I don't think the default HttpResponseFeature is meant to be used. I think the changes are okay though.

@davidfowl davidfowl merged commit b686298 into dev Jun 8, 2017
@davidfowl
Copy link
Member Author

@JunTaoLuo yea the problem is tests not real apps

@JunTaoLuo JunTaoLuo deleted the davidfowl/no-throw branch June 8, 2017 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidfowl @JunTaoLuo @dnfclas