Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Use EscapeDataString for encoding Cookies #546

Merged
merged 1 commit into from
Jan 29, 2016
Merged

Conversation

BrennanConroy
Copy link
Member

[InlineData("key=value", "key", "value")]
[InlineData("key%2C=%21value", "key,", "!value")]
[InlineData("ke%23y%2C=val%5Eue", "ke#y,", "val^ue")]
public void EscapesKeyValuesBeforeSettingCookie(string expected, string key, string value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why do people keep putting expected first? Shouldn't that be last?

@Tratcher
Copy link
Member

:shipit:

@BrennanConroy BrennanConroy merged commit 765a520 into dev Jan 29, 2016
@BrennanConroy BrennanConroy deleted the brecon/encode_better branch January 29, 2016 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants