Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Add HttpContext.Features, move Get/SetFeature. #383

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Add HttpContext.Features, move Get/SetFeature. #383

merged 1 commit into from
Aug 31, 2015

Conversation

Tratcher
Copy link
Member

@davidfowl
Copy link
Member

I'm not sure if it's worth it to make the change in 2 passes? Don't delete the old methods in the first pass and just update the call sites. This will make the ci happy 😀

@davidfowl
Copy link
Member

Besides that the change looks good :shipit:

pranavkm
pranavkm reviewed Aug 30, 2015
View reviewed changes
src/Microsoft.AspNet.Http.Features/FeatureCollectionExtensions.cs
{
public static class FeatureCollectionExtensions
{
public static T Get<T>(this IFeatureCollection features)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFeature + documentation

@Tratcher Tratcher merged commit f475e53 into dev Aug 31, 2015
@Tratcher Tratcher deleted the contextFeatures branch August 31, 2015 04:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tratcher @davidfowl @pranavkm @dnfclas