Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Should HttpContext implement IFeatureCollection? #367

Closed
davidfowl opened this issue Aug 12, 2015 · 6 comments
Closed

Should HttpContext implement IFeatureCollection? #367

davidfowl opened this issue Aug 12, 2015 · 6 comments
Assignees

Comments

@davidfowl
Copy link
Member

Why doesn't it? It would allow users to enumerate features as well. Although Revision would be kinda weird to expose. Some of the properties could be implicit implementation

@davidfowl davidfowl changed the title HttpContext should implement IFeatureCollection Should HttpContext implement IFeatureCollection? Aug 12, 2015
@Tratcher
Copy link
Member

I think a direct implementation would be awkward, like the indexer that takes a type and returns an object. Features are an advanced topic that most users won't ever deal with. Why not just add a IFeatureCollection Features { get; } property? And move Get/SetFeature to extensions on IFeatureCollection.

@glennc glennc added this to the Backlog milestone Aug 13, 2015
@davidfowl
Copy link
Member Author

Sounds better.

@Tratcher Tratcher removed this from the Backlog milestone Aug 17, 2015
@Tratcher
Copy link
Member

Dropping out of backlog because it involves breaking changes on the abstract base class.

@Tratcher Tratcher added the bug label Aug 22, 2015
@Tratcher Tratcher added this to the 1.0.0-beta8 milestone Aug 22, 2015
@Tratcher Tratcher self-assigned this Aug 22, 2015
@Tratcher
Copy link
Member

This keeps coming up as a useful way to create the structures for calling TestServer.Invoke directly.

@davidfowl
Copy link
Member Author

Ah to avoid going through the HttpClient?

@Tratcher
Copy link
Member

Yes. HttpClient is convenient but it can only handle simple scenarios. Katana had a separate API that let you set up the server data structures directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants