This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Dispose the host if Initialize fails #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
Jan 29, 2018
|
|
||
| } | ||
|
|
||
| public void ConfigureServices(IServiceCollection services) |
Contributor
There was a problem hiding this comment.
nit: public void ConfigureServices(IServiceCollection services) => throw new InvalidOperationException()
| throw new InvalidOperationException(); | ||
| } | ||
|
|
||
| public void Configure(IApplicationBuilder app) |
Contributor
There was a problem hiding this comment.
nit: continue the trend where empty methods are shortened as public void Foo(...) {}?
Member
Author
There was a problem hiding this comment.
I don't think that's a consistent trend.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1313