This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Change Certificates.Configuration to a Sources package #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this go into Common with the rest of the source packages? |
|
It can't be tested in common, it needs Logging and Configuration. |
|
Ugh this is so arbitrary. |
|
The other idea was to put it in Kestrel's repo so it's at least next to one of its consumers. We've done something similar for StaticFiles & MVC |
|
Note types need to be made internal now. |
Tratcher
force-pushed
the
tratcher/certloader
branch
from
0750438 to
6863e26
Compare
|
Will rebase onto rel/2.0.0-preview2 before committing |
This was referenced Jun 1, 2017
JunTaoLuo
approved these changes
Jun 1, 2017
javiercn
approved these changes
Jun 1, 2017
|
Merged to rel and dev. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only has internal consumers.
Fixes #1098