This repository was archived by the owner on Nov 2, 2018. It is now read-only.
Fix mixed open and close generic service IEnumerable resolution #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
davidfowl
reviewed
Jun 1, 2017
| return null; | ||
| } | ||
|
|
||
| private IServiceCallSite ApplyScope(IServiceCallSite serviceCallSite, ServiceLifetime descriptorLifetime) |
There was a problem hiding this comment.
Change the name to ApplyLifetime, Scope has another meaning
davidfowl
reviewed
Jun 1, 2017
| Validate(descriptors); | ||
| } | ||
|
|
||
| private void Validate(IEnumerable<ServiceDescriptor> descriptors) |
pakrym
commented
Jun 1, 2017
| @@ -680,5 +680,29 @@ public void DisposesInReverseOrderOfCreation() | |||
| Assert.Equal(outer.MultipleServices.Reverse(), callback.Disposed.Skip(1).Take(3).OfType<IFakeMultipleService>()); | |||
| Assert.Equal(outer.SingleService, callback.Disposed[4]); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void ResolvesMixedOpenClosedGenericsAsEnumerable() | |||
There was a problem hiding this comment.
/cc @khellang this test fails on StructureMap
There was a problem hiding this comment.
Yep. That was expected (#500 (comment)). I'll see if I can do some magic internally to get it to work.
davidfowl
reviewed
Jun 1, 2017
|
|
||
| namespace Microsoft.Extensions.DependencyInjection.ServiceLookup | ||
| { | ||
| internal class FactoryService : IService, IServiceCallSite | ||
| internal class FactoryService : IServiceCallSite |
davidfowl
approved these changes
Jun 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #500