Set InvariantGlobalization in BasicMinimalApi #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api template is updating, see dotnet/aspnetcore#47066. This syncs that change here.
captainsafia
approved these changes
Mar 8, 2023
|
Add it to BasicGrpc as well, please. It seems like the direction we're going toward is enabling this setting in all our HTTP API-focused templates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api template is updating, see dotnet/aspnetcore#47066. This syncs that change here.
@JamesNK - I didn't update the Grpc app because we aren't updating the grpc template. Do you think we should make a similar change to the grpc template?