Add scenarios for route handler filters #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
halter73,
davidfowl,
sebastienros,
BrennanConroy and
brunolins16
captainsafia
force-pushed
the
endp-filters
branch
from
eeb7a3a to
59ef6fa
Compare
davidfowl
reviewed
Mar 17, 2022
captainsafia
force-pushed
the
endp-filters
branch
from
59ef6fa to
501497d
Compare
davidfowl
reviewed
Mar 21, 2022
captainsafia
force-pushed
the
endp-filters
branch
from
1c97128 to
92de3b8
Compare
halter73
reviewed
Mar 22, 2022
|
|
||
| return (context) => | ||
| { | ||
| if (hasParams && isStringParam) |
There was a problem hiding this comment.
Nit: This if could be put outside the return (context) => ...
halter73
reviewed
Mar 22, 2022
halter73
approved these changes
Mar 22, 2022
captainsafia
force-pushed
the
endp-filters
branch
from
5e5b8d7 to
5ffd825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/aspnetcore#40655