Add scenarios for route handler filters (#1727)

* Add scenarios for route handler filters

* Add new test scenarios

* Update code samples

Author: captainsafia

build/trend-scenarios.yml

@@ -38,11 +38,18 @@ parameters:
     arguments: --scenario mapaction $(plaintextJobs) --property scenario=PlaintextMapAction --property protocol=http
   - displayName: Plaintext Endpoint
     arguments: --scenario endpoint $(plaintextJobs) --property scenario=PlaintextEndpoint --property protocol=http
+  - displayName: Plaintext (No Filters)
+    arguments: --scenario plainTextSansFilter $(plaintextJobs) --property scenario=PlaintextWithParametersNoFilter --property protocol=http
+  - displayName: Plaintext (Empty Filters)
+    arguments: --scenario plainTextEmptyFilter $(plaintextJobs) --property scenario=PlaintextWithParametersEmptyFilter --property protocol=http
+  - displayName: Plaintext (Empty Filters, No Parameters)
+    arguments: --scenario plainTextNoParamsEmptyFilter $(plaintextJobs) --property scenario=PlaintextNoParametersEmptyFilter --property protocol=http
+  - displayName: Plaintext (With Filters)
+    arguments: --scenario plainTextWithFilter $(plaintextJobs) --property scenario=PlaintextWithParameterstWithFilter --property protocol=http
   - displayName: Plaintext Connection Close
     arguments: --scenario connectionclose $(plaintextJobs) --property scenario=ConnectionClose --property protocol=http --variable connections=32 --property connections=32 
   - displayName: Plaintext Connection Close Https
     arguments: --scenario connectionclosehttps $(plaintextJobs) --property scenario=ConnectionCloseHttps --property protocol=https --variable connections=32 --property connections=32
-  - displayName: Plaintext Connection Close Https HttpSys
     arguments: --scenario connectionclosehttps $(plaintextJobs) --property scenario=ConnectionCloseHttpsHttpSys --property protocol=https --variable connections=32 --property connections=32 --variable server=HttpSys --application.options.requiredOperatingSystem windows
 
 # Json

scenarios/plaintext.benchmarks.yml

@@ -92,6 +92,46 @@ scenarios:
         presetHeaders: plaintext
         path: /plaintext
         pipeline: 16
+  
+  plainTextSansFilter:
+    application:
+      job: mapaction
+    load:
+      job: wrk
+      variables:
+        presetHeaders: plaintext
+        path: /hello/TesterName/42/Internet
+        pipeline: 16
+
+  plainTextEmptyFilter:
+    application:
+      job: mapaction
+    load:
+      job: wrk
+      variables:
+        presetHeaders: plaintext
+        path: /helloEmptyFilter/TesterName/42/Internet
+        pipeline: 16
+  
+  plainTextNoParamsEmptyFilter:
+    application:
+      job: mapaction
+    load:
+      job: wrk
+      variables:
+        presetHeaders: plaintext
+        path: /plaintextNoParamsWithFilter
+        pipeline: 16
+
+  plainTextWithFilter:
+    application:
+      job: mapaction
+    load:
+      job: wrk
+      variables:
+        presetHeaders: plaintext
+        path: /helloFiltered/TesterName/42/Internet
+        pipeline: 16
 
   connectionclose:
     application:

src/BenchmarksApps/MapAction/Program.cs

@@ -1,6 +1,8 @@
 using System;
+using System.Reflection;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
@@ -23,6 +25,32 @@
 
                 object Json() => new { message = "Hello, World!" };
                 endpoints.MapGet("/json", (Func<object>)Json);
+
+                // Parameterized plain-text endpoint
+                string SayHello(string name, int age, string location) => $"Hello, {name}! You're {age} years old and based in {location}.";
+                // With no filters
+                endpoints.MapGet("/hello/{name}/{age}/{location}", SayHello);
+                // With a filter that no-ops
+                endpoints.MapGet("/helloEmptyFilter/{name}/{age}/{location}", SayHello)
+                    .AddFilter((context, next) => next(context));
+                // With filter on endpoint with no parameters
+                endpoints.MapGet("/plaintextNoParamsWithFilter", Plaintext)
+                    .AddFilter((context, next) => next(context));
+                endpoints
+                    .MapGet("/helloFiltered/{name}/{age}/{location}", SayHello)
+                    .AddFilter((routeHandlerContext, next) => {
+                        var hasParams = routeHandlerContext.MethodInfo.GetParameters().Length >= 1;
+                        var isStringParam = routeHandlerContext.MethodInfo.GetParameters()[0].ParameterType == typeof(string);
+
+                        return (RouteHandlerFilterDelegate)((context) =>
+                        {
+                            if (hasParams && isStringParam)
+                            {
+                                context.Parameters[0] = ((string)context.Parameters[0]).ToUpperInvariant();
+                            }
+                            return next(context);
+                        });
+                    });
             });
 
         });