Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Benchmarks.ServerJob/ServerJob.cs
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ public ServerJob ClearServerCounters()
// Other collection options
public bool CollectStartup { get; set; }
public bool CollectCounters { get; set; }

/// <summary>
/// The list of performance counter providers to be collected. Defaults to <c>System.Runtime</c>.
/// </summary>
public List<string> CounterProviders { get; set; } = new List<string>();

public string BasePath { get; set; }
public int ProcessId { get; set; }
public Dictionary<string, string> EnvironmentVariables { get; set; } = new Dictionary<string, string>();
Expand Down
1 change: 1 addition & 0 deletions src/BenchmarksDriver2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Options:
--[JOB].dotnetTraceProviders <profile|flags> An optional profile name or list of dotnet-trace providers can be passed. Default is 'cpu-sampling'. See https://github.com/dotnet/diagnostics/blob/master/documentation/dotnet-trace-instructions.md for details. e.g., Microsoft-DotNETCore-SampleProfiler, Microsoft-Windows-DotNETRuntime, gc-verbose. Can be used multiple times to set multiple providers.
--[JOB].options.traceOutput <filename> The name of the trace file. Can be a file prefix (app will add *.DATE*.zip) , or a specific name and no DATE* will be added e.g., c:\traces\mytrace
--[JOB].collectCounters <true|false> Whether to collect dotnet counters.
--[JOB].counterProviders <provider> The name of a performance counter provider from which to collect.
--[JOB].collectStartup <true|false> Whether to includes the startup phase in the traces, i.e after the application is launched and before it is marked as ready. For a web application it means before it is ready to accept requests.

## Environment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public SessionConfiguration(uint circularBufferSizeMB, EventPipeSerializationFor
throw new ArgumentException("Unrecognized format");
if (providers == null)
throw new ArgumentNullException(nameof(providers));
if (providers.Count() <= 0)
if (providers.Count <= 0)
throw new ArgumentException($"Specified providers collection is empty.");

CircularBufferSizeInMB = circularBufferSizeMB;
Expand All @@ -37,7 +37,6 @@ public SessionConfiguration(uint circularBufferSizeMB, EventPipeSerializationFor
public uint CircularBufferSizeInMB { get; }
public EventPipeSerializationFormat Format { get; }


public IReadOnlyCollection<Provider> Providers => _providers.AsReadOnly();

private readonly List<Provider> _providers;
Expand Down
Loading