-
Notifications
You must be signed in to change notification settings - Fork 80
Microsoft.AspNet.Http and Microsoft.AspNet.Http.Core package names swapped #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If your intent is for most projects to only need to reference the abstract base classes, why put them in a sub namespace? I can already predict that I (and likely many others) will forget this guidance and assume they need to reference Why not put all the concrete classes and implementations that you do NOT intend developers to have to refer to often in, for example, |
Uuuh... @bitcrazed, I think @Tratcher mentioned that there is no sub-namespace. Everything is under the same namespace:
There are two different packages, which IMO is great. If you only want the contracts, grab Http.Core, otherwise, grab Http. Though I doubt most people will ever explicitly grab any of the packages. In most cases they'll be implicit dependencies. |
I think @bitcrazed's concern (correct me if I'm wrong) is with the package name, not the namespace. i.e. that I would personally argue that the current package rename makes sense. The |
I'm fine with having
|
Ugh. Apologies. Reading is hard ;) Happy that there's no namespace splitting and yes, like @khellang, I like the idea of only having to bring in one package if I don't need the concrete implementation. However, I would think it more logical to put the interfaces and abstract classes, etc. in, for example As a name, |
I happen to agree with the described split in the announcement 😄 |
How about being explicit? |
RE: aspnet/HttpAbstractions#190
These two packages have swapped names. Http.Core now contains the abstract base classes for HttpContext, etc, and interfaces like IApplicationBuilder. Http now depends on Http.Core and contains an implementation of those base classes and interfaces with like DefaultHttpContext. Most projects will only need a reference to the Http.Core package.
Note that there is no longer an Http.Core namespace, the items from both packages have been put into the Http namespace.
The text was updated successfully, but these errors were encountered: