Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Rename Http.Core/Http packages #190

Closed
danroth27 opened this issue Feb 11, 2015 · 8 comments
Closed

Rename Http.Core/Http packages #190

danroth27 opened this issue Feb 11, 2015 · 8 comments
Assignees
Milestone

Comments

@danroth27
Copy link
Member

Currently Microsoft.AspNet.Http.Core depends on Microsoft.AspNet.Http, which seems backwards.

@danroth27 danroth27 changed the title Http should depend on HttpCore, not the other way around Http should depend on Http.Core, not the other way around Feb 11, 2015
@Tratcher
Copy link
Member

Http contains the abstract HttpContext that most apps will reference directly, where Http.Core contains an actual implementation primarily referenced by Hosting. The naming of Http.Core could be better, but I think swapping it with Http would be detrimental to HttpContext.

@danroth27 danroth27 changed the title Http should depend on Http.Core, not the other way around Rename Http.Core package Feb 11, 2015
@danroth27 danroth27 changed the title Rename Http.Core package Rename Http.Core/Http packages Feb 11, 2015
@danroth27
Copy link
Member Author

How about Http -> Http.Abstractions?

@Tratcher
Copy link
Member

I don't recommend it. Just about everything in the pipeline references HttpContext, so it should stay in the top level Http namespace and package for ease of discovery and usage.

@danroth27
Copy link
Member Author

We can argue about the new names, (I'm fine with just renaming Http.Core to something else), but the current names have to change somehow. Everywhere else that I know of in Core is the thing that other stuff depends on, not the other way around. Think .NET Core vs .NET Framework.

@davidfowl
Copy link
Member

Http.Impl yay java

@davidfowl
Copy link
Member

@danroth27 Did you have any more thoughts on this?

@davidfowl
Copy link
Member

We decided to swap the names:

  • Http.Core - Abstractions
  • Http - Implementations

/cc @glennc @muratg @lodejard

@Tratcher
Copy link
Member

Put everything in the Http namespace.

  • Http.Core - Abstract base classes, used to implement middleware
  • Http - Implementations, only referenced by Hosting & tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants