Add linting for unsorted-dict-items #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables linting and automatic fixing for the non-default buildifier
unsorted-dict-items
warning. This ensures that the dictionary of configuration versions inversions.bzl
stays sorted.Fixes #88. Note that the "buildifier: keep sorted" directive appears undocumented and limited to lists. As far as I can tell, enabling this warning for the whole project and adding comments to disable as needed is the only currently available solution to achieve the desired behavior through buildifier.
It's perfectly fine to deny this change if you don't like having this behavior throughout this codebase.
Changes are visible to end-users: yes
Test plan