Skip to content

[FR]: Use typescript from npm_translate_lock #624

@Silic0nS0ldier

Description

@Silic0nS0ldier

What is the current behavior?

As of #308 the TypeScript version and integrity can be automatically extracted, however this misses out on functionality present in npm_translate_lock such as applying patches.

A recent TypeScript release included a bug microsoft/TypeScript#57849 (5.4.x, broken in 5.4.2 and fixed in 5.4.5) which was fixed with a trivial patch, however it could not be applied to Rules TS's @npm_typescript repo.

Describe the feature

Instead of pulling in TypeScript with bespoke logic

http_archive_version = repository_rule(

support using TypeScript from npm_translate_lock's node_modules directly. This way functionality like patching comes free.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestneed: discussionWe have to do some design work in a meeting

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions