[feature] Cors additions / GetTokenFromSecret #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORS support and GetTokenFromSecret to internal APIs
This small update adds CORS support to the internal GetObjectLocation request and enables the dataproxy to create short-lived api tokens on behalf of the user via s3 credentials.
With this the dataproxy can use these tokens to modify API resources via the public API directly without the need for extra internal requests.
Changelog
GetTokenFromSecretrpc to internal authorize service.CorsConfigurationtoGetObjectLocationResponsein internal proxy notifier. ([feat] CORS Configuration proxy#29)Breaking Changes
No breaking changes for the public API were introduced.