Skip to content

feat(object-code): compatible with versions below typescript 5.2.0 (WeakKey) #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wangcch
Copy link
Contributor

@wangcch wangcch commented Feb 8, 2024

For more compatibility, hope to remove the use of WeakKey

WeakKey is referenced after typescript 5.2.0

microsoft/TypeScript#54195

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fcbcbc) 99.15% compared to head (0f58b05) 99.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          18       18           
  Lines         237      237           
  Branches       68       68           
=======================================
  Hits          235      235           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurfiorette
Copy link
Owner

thanks!

@arthurfiorette arthurfiorette merged commit e078f73 into arthurfiorette:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants