-
-
Notifications
You must be signed in to change notification settings - Fork 700
Transition testing framework to pytest #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1669 1669
Branches 282 282
=====================================
Hits 1669 1669Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jadchaar solid PR, pytest looks so much better than Chai. I've taken a quick look over and just have one initial comment, I'll review in depth later on.
|
Hey @jadchaar I was able to successfully clone your branch and run the new tests, everything passed fine. |
|
Fantastic. I have locked the dependency versions like you requested. |
|
Looks like the last version of pytest to support 2.7 is 4.6 (https://docs.pytest.org/en/latest/py27-py34-deprecation.html). 😞 |
|
@systemcatch I pushed a fix for this in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my end Jad, I'll leave merging to you in case there's anything extra you want to add.
|
I don't have anything to add :). I'll go ahead and merge this. |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Closes: #594
This is the first iteration of the transition to Pytest. We should ultimately move away from the x-unit style of
setUp()functions to native Pytest fixtures, but this will do for now.