Skip to content

Conversation

@jadchaar
Copy link
Member

@jadchaar jadchaar commented Jan 4, 2020

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Closes: #594

This is the first iteration of the transition to Pytest. We should ultimately move away from the x-unit style of setUp() functions to native Pytest fixtures, but this will do for now.

@jadchaar jadchaar requested a review from systemcatch January 4, 2020 22:14
@codecov-io
Copy link

codecov-io commented Jan 4, 2020

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #751   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1669   1669           
  Branches      282    282           
=====================================
  Hits         1669   1669

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c856ab9...c1ca3b0. Read the comment docs.

Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jadchaar solid PR, pytest looks so much better than Chai. I've taken a quick look over and just have one initial comment, I'll review in depth later on.

@systemcatch
Copy link
Collaborator

Hey @jadchaar I was able to successfully clone your branch and run the new tests, everything passed fine.

@jadchaar
Copy link
Member Author

jadchaar commented Jan 8, 2020

Fantastic. I have locked the dependency versions like you requested.

@systemcatch
Copy link
Collaborator

Looks like the last version of pytest to support 2.7 is 4.6 (https://docs.pytest.org/en/latest/py27-py34-deprecation.html). 😞

@jadchaar
Copy link
Member Author

jadchaar commented Jan 9, 2020

@systemcatch I pushed a fix for this in the latest commit.

Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end Jad, I'll leave merging to you in case there's anything extra you want to add.

@jadchaar
Copy link
Member Author

I don't have anything to add :). I'll go ahead and merge this.

@jadchaar jadchaar merged commit 2b3dfe4 into arrow-py:master Jan 10, 2020
@jadchaar jadchaar deleted the testsuite-revamp branch January 10, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition testing framework from nose/chai to pytest

3 participants