JSON escape complex strings in Slack attachments JSON (#8665)

[pclalv]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

Fixes #8665

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.25%. Comparing base (be042c4) to head (e06d459).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11098      +/-   ##
==========================================
+ Coverage   60.23%   60.25%   +0.01%     
==========================================
  Files         346      346              
  Lines       59212    59212              
==========================================
+ Hits        35668    35678      +10     
+ Misses      20664    20658       -6     
+ Partials     2880     2876       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[christoffer-eide]

+1 for documenting this

js is not meant to escape JSON, it's meant for javascript.

For example, it generates invalid JSON if the string contains ' (single quote):
#8665 (comment)

There are probably other scenarios where js won't work 🤷‍♂️

[thiagowfx]

Confirming that js works and is a step in the right direction (even if not a full solution).

[andrii-korotkov-verkada]

Closed the PR due to it being old and unlikely to be able to resolve merge conflicts. But feel free to re-open/re-submit if the work is still planned.

[STASiAN]

Is only the rebase needed?

[bunnyshell]

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[andrii-korotkov-verkada]

Maybe only rebase, but it's been a while, maybe more is needed