Skip to content

Conversation

@pheest
Copy link

@pheest pheest commented Jun 16, 2022

No description provided.

@MarkRivers
Copy link
Member

MarkRivers commented Jun 16, 2022

This PR contains 3 large .log files. Do these belong in the repository, or should they be added to .gitignore?

@MarkRivers
Copy link
Member

There is still one more log file.

@pheest
Copy link
Author

pheest commented Jun 16, 2022

Oops, sorry about that. I've deleted the files from the request.

NB, the build scripts reference my (much more significant) pull requests at ADCore and ADSupport.
This should of course be changed after these have been processed.

@ericonr
Copy link
Member

ericonr commented Dec 17, 2025

This runs gitlab CI. Is there any way to send the results back into this repository?

Were your ADCore and ADSupport changes merged?

@pheest
Copy link
Author

pheest commented Dec 31, 2025

Hi, this is so long ago, I am struggling to remember the details.

The point of the project was to CI build areaDetector modules with MinGW on an Ubuntu runner.
This was not easy.

No, there is no way now to upload the results, but I did get it working.

My related pull request(s) are:
areaDetector/ADSupport#39 (remains open). That is more significant than this one.
areaDetector/ADCore#481 (was closed Jan 1 2024).

I am inclined to say this PR should be deleted, but preferably the ADSupport PR should be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants